-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
リトライ処理の改善 #192
Merged
Merged
リトライ処理の改善 #192
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- パケット読み込みでブロックしているため、ogg 変換と処理を分ける
- opus から ogg への変換処理を共通化する
voluntas
reviewed
Dec 2, 2024
voluntas
reviewed
Dec 2, 2024
voluntas
reviewed
Dec 2, 2024
voluntas
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes several changes to improve the handling of audio streaming and error management in the
amazon_transcribe
,handler
,amazon_transcribe_handler
,packet_dump_handler
, andspeech_to_text_handler
files. The most important changes include adding a new logging library, updating function parameters, improving error handling, and modifying the retry logic.Logging Improvements:
zerolog
for improved logging capabilities inamazon_transcribe.go
.Function Parameter Updates:
Start
method inamazon_transcribe.go
to useio.ReadCloser
instead ofio.Reader
.Handle
method inamazon_transcribe_handler.go
,packet_dump_handler.go
, andspeech_to_text_handler.go
to acceptchan opusChannel
instead ofio.Reader
. [1] [2] [3]Error Handling Enhancements:
Start
method by adding a log statement for errors inamazon_transcribe.go
.handler.go
to manage server disconnections and retries more effectively. [1] [2]Retry Logic Modifications:
handler.go
to use a timer and handle retries more gracefully.amazon_transcribe_handler.go
andspeech_to_text_handler.go
. [1] [2]Test Updates:
handler_test.go
to match the updated logic. [1] [2] [3] [4] [5] [6]下記の 3 点を改善しています
リトライカウントをリセットするタイミングを、サービスへの接続が成功した時点に変更
サービスへのパケット送信でエラーが生じた場合、io エラーとして扱い、解析結果の送信処理と分けるように変更
クライアントからの opus パケットの受信処理と、ogg への換処理を分離